Skip to content

Draft: Fix wire notifs #2294

Ben requested to merge fix/wire-notifs-2294 into master

Ticket(s) / Related Merge Requests

#2294 (closed)

Summary of Changes

Reverts a change made in !866 (merged) that was stopping the repository from returning a Wire entity when resolving from URN

Also stops wire notifs from being filtered out on notifications get, due to the lack of an associated entity.

Testing Considerations

I'm not entirely sure how to go about QAing this as I believe the changes are being run by runners, which aren't updated with these changes.

Make a wire from channel a to channel b - check channel b's notifications. Ensure other notifications work.

Regression Scope

It's strange that a reversion to the changes in !866 (merged) fix this - is there somewhere that we resolve a wire entity that this is going to break?

Platform Affected (web, mobile, etc)

Engine - web and mob.

Developer Testing Completed

Manual

Screenshots

image

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode
Edited by Ben

Merge request reports