Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • Minds Backend - Engine Minds Backend - Engine
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 243
    • Issues 243
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge requests
  • !384

[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ben requested to merge fix/blog-media-nsfw-update-1936 into master Oct 23, 2019
  • Overview 25
  • Commits 20
  • Pipelines 18
  • Changes 9

Closes front#1936 (closed)

Depends on front!613 (merged)

Summary

This change moves future blogs and media posts from the mature blog system, to the NSFW blog system. When creating a new blog. When editing existing values must be shown.

  • The selection should propagate to the media entity.
  • Changes via edit should also propegate

Testing

  1. Make video post with NSFW
  2. Edit the activity and change the NSFW tags to other, so that the mask goes away
  3. Refresh, see no mask
  4. Go to the media page for the actiity, and edit to Pornography.
  5. Checking back widgets, activity and blog post should have updated with flag.

Repeat for posting standard text posts, images and blogs.

Issues I'm aware of

  • The pre-existing value for the NSFW selector is not respected, it must be clicked before it will register something as NSFW.
  • Live update of NSFW in sidebar widgets - I would prefer to leave this out of this, and add that in at a later date. With the amount of testing involved change-detection fixes are not something I want to add into the mix.
  • Image posts are not propagating to sidebar widget; handled here #1150 (closed) Blogs and Video should be
  • Comments are still on the mature system - that is out of scope of this change.
Edited Dec 04, 2019 by Ben
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/blog-media-nsfw-update-1936