Skip to content

[engine] Embedded comment attachments minds/plugins/embedded-comments#2

Ben requested to merge feat/comment-img-e2 into master

Ticket(s) / Related Merge Requests

Summary of Changes

Embedded comment attachments

Testing Considerations

To test you will need to pull down minds/plugins/embedded-comments!1 (merged) and set the proxy in the package.json to https://c81e728d9d4c2f636f067f89cc14862c.bens-networks-2.oke.minds.io/

You will then be able to access via http://localhost:3000/plugins/embedded-comments/?pageUrl=https://developers.minds.com/docs/plugins/embedded-comments&ownerGuid=1540482017907445

  • Comment images display and work.
  • Comment videos are represented as [Video] (contrary to the issue card - the original plan of iframes was not suitable).
  • You can comment with your own videos and images. (note: webhook seems broken on sandboxes, videos will appear but will always be black screens - unrelated to this MR and not needed to test).

Deployment Considerations

Release the new embedded comments app if pipelines are not already automated.

Ensure you run:

ALTER TABLE minds_entities_object_image ADD COLUMN filename text AFTER deleted;

Regression Scope

Embedded comments app. Comments GraphQL.

Platform Affected (web, mobile, etc)

Web.

Developer Testing Completed

Manual.

Screenshots / Screen Recording

simplescreenrecorder-2024-01-11_10.12.19

Does this impact

  • Localization
  • Dark/light mode
  • Guest mode

Definition of Done Checklist

  • The Acceptance Criteria has been met
  • Code is tested: Testing includes unit/spec, E2E/automated and manual testing
  • Merge requests description has been filled out
Edited by Ben

Merge request reports