Fix issue where type conflict in timestamps caused wire notifications #2294
Ticket(s) / Related Merge Requests
Deploying changes to runners docs docs!84 (merged)
Summary of Changes
Fixes an issue where in Cassandra Timestamps were being incorrectly set as Wire entity timestamps, resulting in entity hydration failures in the NotificationsEventStreamsSubscription.
Reverts part of a previous fix !866 (merged) which no longer works, and was preventing this fix from working.
Testing Considerations
Surface testing - Simply make a wire from channel a to channel b - check channel b's notifications.
Test around the area of wires, making new ones, and anywhere we get wire history - these changes really should only impact wires as no changes have been made to notifications - the only way this could conceivably impact all notifications is if a wire notification incoming with an unexcepted format broke the event stream - which should not happen.
Should ensure mobile is prepared to handle the return of this notification type cc/ @msantang78
Note: If it doesn't work at the time of testing, it's possible the runner got restarted and is back to using the old image (thus my changes aren't present). If this happens DM me.
Deployment Considerations
Needs to be deployed to runners AND prod. Will need to be deployed to sandbox runners for testing also. (will handle this before marking as ready, however making a note in case any more changes come in)
Regression Scope
Affects wire timestamps, as mentioned above in Testing Considerations, most of the regression scope here is around the reading and writing of wires, rather than around notifications - both should still be tested for safety, however.
Platform Affected (web, mobile, etc)
Engine runner change - affects web and mobile.
Developer Testing Completed
Updated unit tests and manual testing
Screenshots / Screen Recording
Does this impact
-
Localization -
Dark/light mode -
Guest mode
Definition of Done Checklist
-
The Acceptance Criteria has been met -
Code is tested: Testing includes unit/spec, E2E/automated and manual testing -
Merge requests description has been filled out