Loading
[V123-specific] - Trade Accounts - #check-lint-warning
Replacing !490 (closed)
Implements TC MR!3326, TC MR!3598
Other related TC MRs:
-
[feature] Trade accounts #check-lint-warning thorchain/thornode!3326 (merged) -
[fix] Record actions/out_txs details for and deduct native outbound fee from Trade and Secured Asset swaps thorchain/thornode!3598 (merged) -
[fix] Pool Asset for Min Slip and Correct Auto Streaming Quantity #check-lint-warnings #check-lint-warning thorchain/thornode!3700 (merged) -
Requires: [V128-specific] Min swap fee thorchain/thornode!3258 (merged)
-
-
[fix] Trade Account Events #check-lint-warning thorchain/thornode!3458 (merged) -
[V129-specific] Allow swaps between Trade Assets and RUNE thorchain/thornode!3465 (merged) -
[V129-specific] Disallow swapping to a trade asset of a native coin thorchain/thornode!3468 (merged) -
[V131-specific] Clean up trade account manager's GetSafeShare arguments to behave consistently when Depth is lower than Units thorchain/thornode!3470 (merged) -
[Version-unspecific] Move Trade Account Deposit and Withdraw events from handlers to manager #check-lint-warning thorchain/thornode!3550 (merged) -
[metrics] Trade Asset Units and Depth thorchain/thornode!3589 (merged) -
( ❌ - Not Applicable) [V134-specific] inRune respected by GetAssetOutboundFee for Synth/Derived/Trade Assets thorchain/thornode!3573 (merged) -
Fix trade account unit tests thorchain/thornode!3649 (merged) -
[Historical querier panics] Return checkInvariants error on endpoint panic, and fix AsgardInvariant panics thorchain/thornode!3718 (merged) -
[V136-specific] Constant to disable manual swaps to synth (in favour of Trade Asset use instead) thorchain/thornode!3630 (merged) -
NOT SURE [V137-specific] Pendulum proportional under/overestimation of secured Assets and toggles for attention to vaults liquidity and effective security thorchain/thornode!3755 (merged) -
[Version-unspecific] Querier quotes Trade Asset affiliate fee quotes thorchain/thornode!3784 (merged) -
( ❌ - Not Applicable) [APP LAYER]: Secured Assets #check-lint-warning thorchain/thornode!3721 (merged) -
( ❌ - Not Applicable) Secured Asset Manager - stricter and cleaner interface #check-lint-warning thorchain/thornode!3823 (merged) -
[Version-unspecific] Emit after-withdrawal Trade/Secured input amount in swap events, for when smaller than the specified amount #check-lint-warning thorchain/thornode!3870 (merged) -
[v3.2.0-specific] Replace fuzzyAssetMatch's Symbol with the winner's, keeping other fields like Synth and Trade the same #check-lint-warning thorchain/thornode!3759 (merged)
Summary by CodeRabbit
-
New Features
- Introduced trade accounts and trade units for managing trade asset balances.
- Added support for trade account deposits and withdrawals with new message types, memos, and handlers.
- Enabled new API and query endpoints to retrieve trade units and trade account information by asset or address.
- Enhanced swap functionality to support trade assets, including configurable minimum slip fees and gating based on feature flags.
- Integrated trade account management into system lifecycle with version gating and extended internal handler mappings.
- Expanded regression and simulation test suites covering trade account operations and swap scenarios.
-
Bug Fixes
- Improved refund handling to exclude trade assets and refined fee deduction logic for trade and secured assets.
-
Documentation
- Updated OpenAPI specification with endpoints for trade units and trade accounts.
-
Chores
- Increased initial token and liquidity pool allocations in test and simulation setups for improved test scaling.
Edited by ZlyDevMaya