Skip to content
Snippets Groups Projects

chore: Added `get_postorius_default` function and retrieve default for mass_subscription_pre_verify

Merged Alan So requested to merge ktso/postorius:postorius-default-preverify into master
All threads resolved!

Added get_postorius_default function from POSTORIUS_DEFAULTS in settings.py and retrieve default for mass_subscription_pre_verify Related to enhancement request #563 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Alan So

      Thanks for taking this up @ktso! I added a minor comment but the changes are fine.

      This would need a test case with a few scenarios tested (non-default settings show up when form is initialized, missing settings doesn't error out and uses the right default value).

      You can take a look at class TestListMassSubscription in tests/test_list_forms.py. You can use django.test.override_settings decorator (or as context manager, with statement) to test the above scenarios.

      Please also add a NEWS item under doc/news.rst

  • Alan So added 2 commits

    added 2 commits

    • ad403e7c - chore: Update mass_subscription_pre_verify default value retrieval
    • 1a84084b - Added test cases for pre_verified setup in class ListMassSubscription

    Compare with previous version

  • Alan So added 1 commit

    added 1 commit

    • 8bcdf0a6 - Refactor ListMassSubscription form initialization

    Compare with previous version

  • Alan So added 1 commit

    added 1 commit

    Compare with previous version

  • Alan So added 1 commit

    added 1 commit

    Compare with previous version

  • Alan So added 23 commits

    added 23 commits

    • 167d6d13...1275d7f3 - 22 commits from branch mailman:master
    • b6063d1c - Merge branch postorius:master into postorius-default-preverify

    Compare with previous version

  • Alan So resolved all threads

    resolved all threads

  • Alan So marked this merge request as ready

    marked this merge request as ready

  • merged

  • Mark Sapiro mentioned in commit b3ffeeca

    mentioned in commit b3ffeeca

  • @ktso Thank you for your contribution.

  • Danil Smirnov mentioned in merge request !945 (merged)

    mentioned in merge request !945 (merged)

  • Please register or sign in to reply
    Loading