chore: Added `get_postorius_default` function and retrieve default for mass_subscription_pre_verify
Added get_postorius_default
function from POSTORIUS_DEFAULTS in settings.py and retrieve default for mass_subscription_pre_verify
Related to enhancement request #563 (closed)
Merge request reports
Activity
mentioned in issue #563 (closed)
added 1 commit
- 76abe8a8 - chore: minor changes based on output of "tox -e qa"
- Resolved by Alan So
- Resolved by Alan So
Thanks for taking this up @ktso! I added a minor comment but the changes are fine.
This would need a test case with a few scenarios tested (non-default settings show up when form is initialized, missing settings doesn't error out and uses the right default value).
You can take a look at class
TestListMassSubscription
intests/test_list_forms.py
. You can usedjango.test.override_settings
decorator (or as context manager,with
statement) to test the above scenarios.Please also add a NEWS item under
doc/news.rst
added 1 commit
- 8bcdf0a6 - Refactor ListMassSubscription form initialization
added 23 commits
-
167d6d13...1275d7f3 - 22 commits from branch
mailman:master
- b6063d1c - Merge branch postorius:master into postorius-default-preverify
-
167d6d13...1275d7f3 - 22 commits from branch
mentioned in commit b3ffeeca
@ktso Thank you for your contribution.
mentioned in merge request !945 (merged)