Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • extensions extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 77
    • Issues 77
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Inkscape
  • extensionsextensions
  • Merge requests
  • !432

dxf: correct import of extruded elements and multiline text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Neuhauser requested to merge joneuhauser/extensions:dxf-fixes into master Feb 18, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 6

What does the merge request do?

Closes #286 (closed)

This MR fixes the issues raised in the linked issue, in particular, lines with extrude groupcode were displaced, and multiline text with the \P format specifier was incorrectly split. Also, multiline text can not only specify dx=0 for a second line (see http://tutorials.jenkov.com/svg/tspan-element.html), this was rendered as intended in Inkscape but incorrect everywhere else (Inkscape bug? idk)

The fixes were supplied by user Nomura and unit tested by me.

We cannot reasonably expect DXF import to ever be completely correct, so we'll have to wait for particular issues to prioritize.

Implementation notes

Summary for release notes

Further improvements to DXF import.

Checklist

  • Add unit tests (if applicable)
  • Changes to inkex/ are well documented
  • Clean merge request history
Edited Feb 18, 2022 by Jonathan Neuhauser
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: dxf-fixes