Skip to content

Ps2pdf: allow special chars on Windows

Closes #281 (closed)

ps2pdf is a small old batch file, and old batch files tend to have issues with non-Latin characters. Luckily, ps2pdf only calls ghostscript - it's basically just a small helper script so the user doesn't have to remember the CLI options for pdf conversion.

On Windows, gs is called "gswin64c" or "gswin32c", so we look if one of the executables exist and call it with the same options as ps2pdf. (The dependency in the inx definition stays the same, because if ps2pdf exists in PATH, we likely have access to ghostscript as well).

The only interesting part here are the unit tests. The output of ps2pdf is not stable (it includes the timestamp, for example), and slightly different on Windows and Linux, even with the same ghostscript version. I included mock calls for both unit tests to gswin64c, enforced the usage of this executable for CI, and replaced the output in the mock calls by the existing output on Linux. There is not much to win here.

Merge request reports