Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • extensions extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 76
    • Issues 76
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • InkscapeInkscape
  • extensionsextensions
  • Merge requests
  • !408

Ps2pdf: allow special chars on Windows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Neuhauser requested to merge joneuhauser/extensions:ps2pdf-special-chars into master Jan 31, 2022
  • Overview 0
  • Commits 5
  • Pipelines 2
  • Changes 3

Closes #281 (closed)

ps2pdf is a small old batch file, and old batch files tend to have issues with non-Latin characters. Luckily, ps2pdf only calls ghostscript - it's basically just a small helper script so the user doesn't have to remember the CLI options for pdf conversion.

On Windows, gs is called "gswin64c" or "gswin32c", so we look if one of the executables exist and call it with the same options as ps2pdf. (The dependency in the inx definition stays the same, because if ps2pdf exists in PATH, we likely have access to ghostscript as well).

The only interesting part here are the unit tests. The output of ps2pdf is not stable (it includes the timestamp, for example), and slightly different on Windows and Linux, even with the same ghostscript version. I included mock calls for both unit tests to gswin64c, enforced the usage of this executable for CI, and replaced the output in the mock calls by the existing output on Linux. There is not much to win here.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ps2pdf-special-chars