Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • extensions extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 76
    • Issues 76
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • InkscapeInkscape
  • extensionsextensions
  • Merge requests
  • !325

Homogenize default values of inx and python code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Neuhauser requested to merge joneuhauser/extensions:homogenize-default-vals into master May 25, 2021
  • Overview 3
  • Commits 3
  • Pipelines 3
  • Changes 163

This did not spark joy. But after !323 (merged), I earned this.

Well, a bug in my refactoring of the scatter extension was ultimately caused by the fact that python and inx files had different defaults, and therefore my assumptions about unit tests were wrong. This should not happen again.

This MR changes the defaults of the CLI arguments to match those of the inx file. The unit test validating the inx files has been updated as well to check this in the CI. I decided to do it that way because the inx defaults probably had more eyes on them. (The only exception was one change to the function plotter, which should be self-explanatory).

Then I had to rename about 100 out files for the tests, because those too use the old defaults of the py files. The tests were not changed themselves. The only change in the coverage results from the increase in lines in tester/inx.py

Edited May 25, 2021 by Jonathan Neuhauser
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: homogenize-default-vals