Skip to content

Homogenize default values of inx and python code

Jonathan Neuhauser requested to merge joneuhauser/extensions:homogenize-default-vals into master

This did not spark joy. But after !323 (merged), I earned this.

Well, a bug in my refactoring of the scatter extension was ultimately caused by the fact that python and inx files had different defaults, and therefore my assumptions about unit tests were wrong. This should not happen again.

This MR changes the defaults of the CLI arguments to match those of the inx file. The unit test validating the inx files has been updated as well to check this in the CI. I decided to do it that way because the inx defaults probably had more eyes on them. (The only exception was one change to the function plotter, which should be self-explanatory).

Then I had to rename about 100 out files for the tests, because those too use the old defaults of the py files. The tests were not changed themselves. The only change in the coverage results from the increase in lines in tester/inx.py

Edited by Jonathan Neuhauser

Merge request reports