Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GROMACS GROMACS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 316
    • Issues 316
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 92
    • Merge requests 92
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GROMACS
  • GROMACSGROMACS
  • Issues
  • #1893
Closed
Open
Issue created Jan 27, 2016 by Paul Bauer@acmnpvMaintainer

grompp fails to warn about .mdp values with the wrong type - Redmine #1893

For example,

init_lambda_values = 0.35

is silently interpreted as 0.

(from redmine: issue id 1893, created on 2016-01-27 by mark.j.abraham, closed on 2016-02-03)

  • Relations:
    • relates #1026 (closed)
  • Changesets:
    • Revision 937fd932324c73d3881e1f5b431740313dff4a82 by Mark Abraham on 2016-01-27T21:54:39Z:
Make sc-power an integer like it needs to be

This means it can pass the new check.

Refs #1893

Change-Id: I652f383e5914a6475e1640ec8842b7b6cfc8f1d3
  • Revision d0071abf by Mark Abraham on 2016-02-03T12:41:59Z:
Fix grompp not warning when .mdp values have wrong types

With old code, e.g. init_lambda_state = 0.35 was silently
interpreted as 0.

Added some comments and TODOs.

Added unit tests for some simple parts of the the functionality that
needed to be fixed. Extended the interface of warninp_t to permit
sound testing.

Fixes #1893

Change-Id: I425798daa8ed3a391cde49ba4a2d3d352d682f8f
  • Revision fe436f74 by Mark Abraham on 2017-02-02T21:35:39Z:
Clarify use of tau-p and pcoupltype

grompp used to permit "tau-p = 5 5" which is misleading. The recent
fix for #1893 leads to the user receiving a grompp warning, so this
improves the docs to make clear that pressure coupling is not
implemented like temperature coupling (where different time constants
might be used).

Refs #1893

Change-Id: I8328b30a12689795c7af2d12dfc94db11b78a03a
Assignee
Assign to
Time tracking