Skip to content

Improve URI conflict error messages when creating a community

Eric Eastwood requested to merge 1951-better-community-creation-error-message into develop

Improve URI conflict error messages when creating a community

Fix https://gitlab.com/gitlab-org/gitter/webapp/issues/1951

Touching this while working on https://gitlab.com/gitlab-org/gitter/webapp/issues/2393 and checking out the GH_ORG reference in server/api/private/check-group-uri.js

Testing strategy

As a GitHub user, enter the name of a GitHub org you don't control, gitlab-org for example -> There is a URI clash with an org/repo/user on GitHub. Change your community URI to proceed or if you in control of this org/repo, allow private repo access on the GitHub org or make your org membership public. We are currently not allowed to see that you control the GitHub org/repo

As a GitHub user, create a community and select a repo where the name matches the name of some GitHub org -> The name of the GitHub repo you selected conflicts with the name of a GitHub org/user. When you select the a repo "foo/bar", it fills out the community URI as "bar" which clashes another GitHub org/user. Change your community URI to proceed.

As a GitLab user, create a community and enter a name that conflicts with GitHub, gitlab-org for example -> There is a URI clash with an org/repo/user on GitHub. Change your community URI to proceed.

For #github-uri-split details, see gitlab-org&2425 (closed)

Edited by Eric Eastwood

Merge request reports