GitLab group based communities (backend)
Add backend support Gitter communities based on GitLab groups.
Currently we support values like GH_ORG, GH_REPO, and GH_USER which represent the associated entity backing the community/room and the permissions they inherit. These flow down to different systems like avatars, invites, admin discovery, access, etc. This issue tracked the introduction of GL_GROUP into those system.
Frontend: https://gitlab.com/gitlab-org/gitter/webapp/issues/2394
Pre-requisite for GitLab based rooms
Todo
Add equivalent GL_GROUP wherever GH_ORG mentioned
-
modules/collaborators/lib/collaborators-service.js- Not necessary for this iteration -> https://gitlab.com/gitlab-org/gitter/webapp/issues/2410
-
modules/collaborators/test/collaborators-service-test.js- Not necessary for this iteration -> https://gitlab.com/gitlab-org/gitter/webapp/issues/2410
-
scripts/utils/list-invite-user-suggestions.js- Not necessary for this iteration -> https://gitlab.com/gitlab-org/gitter/webapp/issues/2410
-
server/api/private/invite-user-suggestions.js- Not necessary for this iteration -> https://gitlab.com/gitlab-org/gitter/webapp/issues/2410
-
modules/groups/lib/group-avatars.js -
modules/groups/lib/group-service.js -
modules/groups/lib/group-uri-checker.js -
modules/permissions/lib/add-invite-policy-factory.js -
modules/permissions/lib/admin-discovery/github-org.js -
modules/permissions/lib/ensure-access-and-fetch-descriptor.js -
modules/permissions/lib/known-external-access/admin-filter.js -
modules/permissions/lib/policies/gh-org-policy-delegate.js -
modules/permissions/lib/policy-delegate-factory.js -
modules/permissions/lib/policy-factory.js -
modules/permissions/lib/security-descriptor-generator.js -
modules/permissions/lib/security-descriptor-utils.js -
modules/permissions/lib/security-descriptor-validator.js -
modules/permissions/lib/security-descriptor/transform.js -
modules/permissions/test/known-external-access/admin-group-finder.js - No change needed
-
modules/permissions/test/permission-combinations.js -
modules/persistence/lib/schemas/security-descriptor-subdocument.js -
modules/rooms/lib/room-service.js -
scripts/utils/rename-group.js -
server/api/private/check-group-uri.js -
server/api/v1/groups/README.md -
server/api/v1/groups/rooms.js -
server/api/v1/rooms/issues.js- Not necessary for this iteration -> https://gitlab.com/gitlab-org/gitter/webapp/issues/2413
-
modules/rooms/lib/room-repo-service.js- Not necessary for this iteration -> https://gitlab.com/gitlab-org/gitter/webapp/issues/2413
-
server/serializers/rest/group-strategy.js- No change needed
-
server/serializers/rest/troupe-strategy.js- No change needed
-
server/services/org-service.js -
shared/templates/get-header-view-options.js -
test/integration/services/group-with-policy-service-test.js - This is testing the
createRoom()method which we don't need to update. We just supportGL_GROUPcommunities, not rooms yet. And rooms in that community can inherit from the group.
- This is testing the
-
test/request-api-tests/group-api-tests.js -
test/request-api-tests/user-orgs-api-tests.js
Edited by Eric Eastwood