Add GL_GROUP support to ensure-access-and-fetch-descriptor (!1702) · Merge requests · gitter / webapp · GitLab

This is an archived project. Repository and other project resources are read-only.

Eric Eastwood requested to merge gl-group-ensure-access-and-fetch-descriptor into develop Dec 20, 2019

Add GL_GROUP support to ensure-access-and-fetch-descriptor

Part of https://gitlab.com/gitlab-org/gitter/webapp/issues/2393

Used when you create a group to ensure proper access
- https://gitlab.com/gitlab-org/gitter/webapp/blob/b11fb087105fa9044efbc19004758075ad55d463/modules/groups/lib/group-service.js#L153
- https://gitlab.com/gitlab-org/gitter/webapp/blob/b11fb087105fa9044efbc19004758075ad55d463/modules/groups/lib/group-service.js#L168-169
Also used when you create a room under the group to ensure proper access
- https://gitlab.com/gitlab-org/gitter/webapp/blob/b11fb087105fa9044efbc19004758075ad55d463/server/services/group-with-policy-service.js#L134
- https://gitlab.com/gitlab-org/gitter/webapp/blob/b11fb087105fa9044efbc19004758075ad55d463/server/services/group-with-policy-service.js#L70

Split out into multiple MRs:

Todo

add integrationTests__gitlabTestUser__id to GitLab CI
add integrationTests__gitlabGroup1__id to GitLab CI

Edited Jan 08, 2020 by Eric Eastwood