Skip to content

Fail check analyzer version job if version not set

Adam Cohen requested to merge fail-check-analyzer-version-when-version-not-configured into master

What does this MR do?

Now that all analyzers correctly report the current version, we can make the check analyzer version job more strict and ensure it fails if the version is not set.

Background

When the version check job was first added, it would only fail if the analyzer reported a version which was different from the most recent version in the CHANGELOG.md file. If no version was reported at all, then it would simply output a warning and the test would pass. It was implemented this way to allow the job to be added without causing existing analyzers which didn't yet report a version to fail.

Now that all analyzers report the current version, the job can be made more strict, in order to prevent bugs like container Scanning no longer reports analyzer version

What are the relevant issue numbers?

gitlab-org/gitlab#276886 (closed)

Testing

  • Failing test here
  • Successful test here

Related Discussion

See discussion here

Does this MR meet the acceptance criteria?

Edited by Adam Cohen

Merge request reports