Update arg parser to ignore " " as values
What does this MR do?
As part of Synchronize Go version across SAST Analyzers (gitlab-org/gitlab#450634 - closed) • Craig Smith • 17.2 I noticed that removing t.Parallel()
caused some of the unit tests to fail. This is likely happening because of report!42 (comment 1109566192)
This MR removes t.Parallel()
as the performance improvement is negligible, and fixes the resulting broken tests.
This bug is unlikely to have affected customers because it only presents when extra spaces are added to SAST_SCANNER_ALLOWED_CLI_OPTS
, and only --max-memory
is the only argument supported for semgrep.
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests updated/added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Craig Smith