Skip to content

Update arg parser to ignore " " as values

Craig Smith requested to merge craigmsmith-test-arg-parsing into main

What does this MR do?

As part of Synchronize Go version across SAST Analyzers (gitlab-org/gitlab#450634 - closed) • Craig Smith • 17.2 I noticed that removing t.Parallel() caused some of the unit tests to fail. This is likely happening because of report!42 (comment 1109566192)

This MR removes t.Parallel() as the performance improvement is negligible, and fixes the resulting broken tests.

This bug is unlikely to have affected customers because it only presents when extra spaces are added to SAST_SCANNER_ALLOWED_CLI_OPTS, and only --max-memory is the only argument supported for semgrep.

What are the relevant issue numbers?

Synchronize Go version across SAST Analyzers (gitlab-org/gitlab#450634 - closed) • Craig Smith • 17.2

Does this MR meet the acceptance criteria?

Edited by Craig Smith

Merge request reports