Add observability events and collect_sast_scan_metrics_from_pipeline event
What does this MR do?
This events adds observability events to the report module and an interface to easily register custom events. Including this in the report module enables us to easily use observability events in all analyzers that are using this module.
This MR belongs to a chain of MRs we require to include observability data into our analyzers. Their relationship is depicted below.
-
1️⃣ report module (⭐ this MR) Add observability events and collect_sast_scan_... (!102 - merged) • Julian Thome • 18.0 (Adding support for observability event data)-
2️⃣ command module Add interfaces to allow passing data between fu... (command!67 - merged) • Jason Leasure • 18.0 (Adding support for custom serialization and context data) -
3️⃣ tracking calculator https://gitlab.com/gitlab-org/security-products/post-analyzers/tracking-calculator/-/merge_requests/100+s (Bumping the report module in TC so that observability data is passed through the post analyzer)
-
What are the relevant issue numbers?
- Add sast_scan event and test case to the Proces... (gitlab-org/gitlab!186116 - merged) • Julian Thome • 17.11
- Update report and command modules to add suppor... (gitlab-org/gitlab#521626 - closed) • Julian Thome • 18.0 • On track
- Add observability metrics to all report types (gitlab-org/security-products/security-report-schemas!164 - merged) • Michael Eddington • 17.3
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Ensure the report version matches the equivalent schema version -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Julian Thome