Rename `Limiter` classes to 'Filter` and `FilterBuilders` to `SearchBuilders`
The following discussion from !48 (merged) should be addressed:
-
@mlapierre started a discussion: (+5 comments) I extended
BaseConditionsLimiter
for consistency and to use the validation it provides, but I'm not really comfortable with how this behaves so differently fromcalculate
in all the otherConditionsLimiter
classes. This class probably shouldn't extendBaseConditionsLimiter
, unless maybe I change the name of this method so it's at least clear it's not the same kind of method?But then this class would still operate over all resources at once, rather than one at a time like in the other
ConditionsLimiter
classes.What do you think, @markglenfletcher, @rymai, @godfat?
@godfat suggested:
Actually, to think about it, I feel the current limiters should actually be filters, and here we're adding a limiter...
There are also FilterBuilders
that are used to search for resources, so they could be renamed to SearchBuilders