Skip to content

Clarify the error message to advise to edit the MR to enable squashing

Nick Veenhof requested to merge nick_vh-master-patch-91003 into master

What does this MR do and why?

In gitlab-org/gitlab!93269 (closed) I was confused with the error message "[ ] 0874acc6b15cf34842b73ab957099627efe7b10b: If you are applying suggestions, enable squash in the merge request and re-run the danger-review job.". I was looking everywhere except for within the edit region of the MR. I was used to seeing the squash commit checkbox in the frontend as shown in the screenshot below

image

This MR clarifies the error message so that the next person no longer wastes time fixing this.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rémy Coutable

Merge request reports

Loading