2018-12-11: 11.6.0 exception request for gitlab-org/gitlab-ce!23163
Exception request
- Merge request to be considered for picking: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23163
Why it needs to be picked
This merge requests ensures compatibility between Auto DevOps SAST job and the Group Security Dashboard. If not included, users will not be able to use both features at the same time.
More information in https://gitlab.com/gitlab-org/gitlab-ce/issues/54160.
Potential negative impact of picking
The change affects the Auto DevOps template only, with syntax change for the artifacts
section.
In the worst case, the Auto DevOps pipeline will fail the sast
job, that is set as allowed to fail, so other jobs will not be affected. The new version has been tested in production and gave no errors.
Release manager sign-off
(Assign this issue to RMs managing this release. See https://about.gitlab.com/release-managers/)
A release manager (not a trainee) needs to provide initial approval for this exception request.
-
Release manager
Mention others as necessary during discussion.
Sign-off for RC (delete this section if patch release)
Upon initial approval, the release manager will then ping and assign the following roles:
-
Engineering Manager -
Director of Engineering department (if different from Engineering Manager) -
Engineering Manager, Quality
If you are the last person to provide initial approval, assign this issue to the VPE for their approval:
-
VPE
After approval
Check that the following is accurate before closing this issue:
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23163 has the correct milestone and label set so that the release managers will pick it. -
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23163 has a comment with a link to this issue: - Exception approved in #593 (closed)