Skip to content

Don't remove assignees from blog post MR

Steve Abrams requested to merge dont-remove-assignees into master

What does this MR do and why?

The DeployBlogPost service and it's matching job in the security release pipeline does a few things:

  • Assigns to release managers
  • Approves the MR
  • Adds the MR to the merge train

When it assigns to release managers, it currently edits the MR, updating the assignee list to only include the release managers. This means that if anyone was already assigned, they will be removed.

When we generate the blog MR on the security mirror, it is assigned to release managers and AppSec release managers. When we move it to canonical the list of assignees is persisted. We saw the AppSec assignees get removed in the recent release: gitlab-com/www-gitlab-com!130900 (closed).

Screenshot_2023-10-31_at_4.04.09_PM

In this MR, we update the logic in DeployBlogPost to simply remove the additional assignement in DeployBlogPost since everyone will already be assigned when it is moved over, so we don't need to duplicate that function.

Related to gitlab-com/gl-infra/delivery#19799 (closed)

Author Check-list

  • [-] Has documentation been updated?
Edited by Steve Abrams

Merge request reports