Don't remove blog MR assignees on approval and deployment
Problem
The DeployBlogPost service and it's matching job in the security release pipeline does a few things:
- Assigns to release managers
- Approves the MR
- Adds the MR to the merge train
When it assigns to release managers, it currently edits the MR, updating the assignee list to only include the release managers. This means that if anyone was already assigned, they will be removed.
When we generate the blog MR on the security mirror, it is assigned to release managers and AppSec release managers. When we move it to canonical the list of assignees is persisted. We saw the AppSec assignees get removed in the recent release: gitlab-com/www-gitlab-com!130900 (closed)
Solution
When we assign to release managers in DeployBlogPost
, do not remove existing assignees.
Edited by Steve Abrams