Ensure processors that should only act on opened resources correctly filter resources based on their state
What does this MR do and why?
While performing a bulk migration in triage-ops!944 (closed), notifications were wrongly sent to merged MRs because we didn't filter out these, e.g. gitlab-org/gitlab!60801 (comment 717459533) and gitlab-org/gitlab!61977 (comment 717453560).
This MR fixes that by ensuring relevant processors only act on opened resources.
This also improves specs overall.
Action items
-
When adding a new Processor
, verify that it has been added to theDEFAULT_PROCESSORS
intriage/triage/handler.rb
in the appropriate order. -
If applicable, identify the affected groups and how to communicate to them: -
/cc @ person_or_group
=> -
Relevant Slack channels => -
Week-in-review
-
Edited by Rémy Coutable