Skip to content

Fix ReviewAppChildPipeline to properly detect variable

Rémy Coutable requested to merge fix-review-app-child-pipleine-config into master

What does this MR do and why?

Variables are passed as [{ 'key' => 'actual_key', 'variable' => 'actual_value' }] in the event payload. Detection should take that inaccount.

I also added a default

    it 'returns true' do
      expect(described_class.match?(event)).to be_truthy
    end

test case for each config classes as the default/positive case wasn't actually tested!

Expected impact & dry-runs

We should start to see notifications coming in the #review-apps-broken channel.

Action items

Edited by Rémy Coutable

Merge request reports