Skip to content

Rename Event#by_team_member? to Event#team_member_author?

Rémy Coutable requested to merge fix-by_team_member-method into master

What does this MR do and why?

Some community-related processors' conditions were wrong as they checked for the issuable author instead of the event actor.

The firsts commit renames Event#by_team_member? to Event#team_member_author?, the second one introduces Event#by_team_member? which checks that the event actor is a team member.

Following are the processors that use this method:

triage/processor/community/command_mr_help.rb:      event.by_team_member? ? 100 : 1
triage/processor/community/command_mr_request_review.rb:      event.by_team_member? ? 100 : 1
triage/processor/community/community_processor.rb:        (event.by_resource_author? || event.by_team_member?)
triage/processor/community/remove_idle_labels_on_activity.rb:        (event.by_resource_author? || event.by_team_member?) &&

Expected impact & dry-runs

Community reactive actions should now be available to team members.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review
Edited by Rémy Coutable

Merge request reports