Skip to content

Introduce a new `ResetReviewState` processor

Rémy Coutable requested to merge 1067-consider-removing-automation-reviewers-reminded-when-workflow-in-dev-is-added-for-community into master

What does this MR do and why?

This MR introduces a new ResetReviewState processor that removes the automation:reviewers-reminded when the workflowin dev label is added to a Community contribution.

That way, this "resets" the "review state" that the automation:reviewers-reminded represents (this label is set so that we don't spam unresponsive reviewers more than once).

The reasoning is that, since automation:reviewers-reminded is added when a Community contribution is in the workflowready for review state for too long (according to our SLOs), if the MR goes back to the workflowin dev state, it means we're not waiting on the reviewer anymore, but we could in the future (when workflowready for review is set and SLO is not respected), and we want to nudge the reviewer again in that case.

This MR also includes a refactor commit ("Consolidate workflow_ready_for_review_added? in CommunityProcessor").

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-with-a-dry-run on how to perform dry-runs.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review

Closes #1067 (closed)

Edited by Rémy Coutable

Merge request reports