Skip to content

Draft: Add a policy to ping inactive reviewers on community MRs

Rémy Coutable requested to merge 897-ping-team-members-in-mrs-that-are-waiting-for-a-review into master

What does this MR do and why?

This adds a policy to ping Community contribution reviewers on MRs that match all the following conditions:

The policy ask the reviewer to review or reassign someone else. The reviewer is also nudged to add workflowin dev if they're waiting on the MR author.

If the reviewer doesn't take any action, the policy will fire after 5 days again (since posting a comment counts as an MR update), unless:

  • the reviewer changes the MR assigned reviewers (which counts as MR update), or
  • add the workflowin dev label, or
  • any other update to the MR happens

Following is a sample message:

@ratchade, this ~"Community contribution" has been assigned to you for review and inactive for 5 days. Can you please review it or assign another reviewer if you do not have availability?

Please add the ~"workflow::in dev" label if the merge request needs actions from the author.

Closes #897 (closed).

Expected impact & dry-runs

Based on https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/2492652260, it would ping reviewers on 36 Community contribution MRs.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review
Edited by Rémy Coutable

Merge request reports