Skip to content

Resolve "Make AppSec review comments for JiHu contributions in the CNG repository"

Lin Jen-Shin requested to merge 907-fix-approval-messages into master

What does this MR do and why?

Request AppSec review outside of gitlab-org/gitlab>. To minimize the noise, this message does not mention triggering a new pipeline because other projects might be using merge train which does not have the concern to trigger a new pipeline.

Expected impact & dry-runs

The message will look like this:

:wave: `@approver`, thanks for approving this merge request.

This is the first time the merge request is approved. Please wait for AppSec approval.

cc @gitlab-com/gl-security/appsec this is a ~"JiHu contribution", please follow the [JiHu contribution review process](https://about.gitlab.com/handbook/ceo/chief-of-staff-team/jihu-support/jihu-security-review-process.html#security-review-workflow-for-jihu-contributions).

It's a bit different before !1078 (merged) but maybe it's fine to be more polite so both messages can look more similar.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review

Closes #907 (closed)

Edited by Lin Jen-Shin

Merge request reports