Thursday 2022-11-17 13:30 UTC - `gitlab-org/gitlab` broken `master` with 1 failed jobs

added Engineering Productivity master-brokenundetermined master:broken labels

changed the incident status to Acknowledged

marked #177 (closed) as a duplicate of this issue

marked this issue as related to #177 (closed)

marked #178 (closed) as a duplicate of this issue

marked this issue as related to #178 (closed)

marked #179 (closed) as a duplicate of this issue

marked this issue as related to #179 (closed)

marked #180 (closed) as a duplicate of this issue

marked this issue as related to #180 (closed)

assigned to @alinamihaila

Failures:
  1) HamlLint::Linter::DocumentationLinks help_page_path behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint
     Failure/Error: it { is_expected.not_to report_lint }
       expected that a lint would not be reported, but reported 1 lint:
         - Line 1: anchor (overview) is missing in: /builds/gitlab-org/gitlab/doc/index.md
     Shared Example Group: "link validation rules" called from ./spec/haml_lint/linter/documentation_links_spec.rb:99
     # ./spec/haml_lint/linter/documentation_links_spec.rb:22:in `block (4 levels) in <main>'
     # ./spec/spec_helper.rb:412:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:404:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:400:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:59:in `with_raw_context'
     # ./spec/spec_helper.rb:400:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:240:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
  2) HamlLint::Linter::DocumentationLinks help_page_url behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint
     Failure/Error: it { is_expected.not_to report_lint }
       expected that a lint would not be reported, but reported 1 lint:
         - Line 1: anchor (overview) is missing in: /builds/gitlab-org/gitlab/doc/index.md
     Shared Example Group: "link validation rules" called from ./spec/haml_lint/linter/documentation_links_spec.rb:103
     # ./spec/haml_lint/linter/documentation_links_spec.rb:22:in `block (4 levels) in <main>'
     # ./spec/spec_helper.rb:412:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:404:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:400:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:59:in `with_raw_context'
     # ./spec/spec_helper.rb:400:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:240:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
Finished in 6.08 seconds (files took 48.14 seconds to load)
3 examples, 2 failures
Failed examples:
rspec './spec/haml_lint/linter/documentation_links_spec.rb[1:1:1:2:1]' # HamlLint::Linter::DocumentationLinks help_page_path behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint
rspec './spec/haml_lint/linter/documentation_links_spec.rb[1:2:1:2:1]' # HamlLint::Linter::DocumentationLinks help_page_url behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint

Reproduced in local env

gitlab git:(master) bin/rspec spec/haml_lint/linter/documentation_links_spec.rb
warning: parser/current is loading parser/ruby27, which recognizes2.7.6-compliant syntax, but you are running 2.7.5.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
.F.............F............

Failures:

  1) HamlLint::Linter::DocumentationLinks help_page_path behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint
     Failure/Error: it { is_expected.not_to report_lint }
     
       expected that a lint would not be reported, but reported 1 lint:
         - Line 1: anchor (overview) is missing in: /Users/alinamihaila/Documents/work/gitlab-development-kit/gitlab/doc/index.md
     Shared Example Group: "link validation rules" called from ./spec/haml_lint/linter/documentation_links_spec.rb:99
     # ./spec/haml_lint/linter/documentation_links_spec.rb:22:in `block (4 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <top (required)>'

  2) HamlLint::Linter::DocumentationLinks help_page_url behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint
     Failure/Error: it { is_expected.not_to report_lint }
     
       expected that a lint would not be reported, but reported 1 lint:
         - Line 1: anchor (overview) is missing in: /Users/alinamihaila/Documents/work/gitlab-development-kit/gitlab/doc/index.md
     Shared Example Group: "link validation rules" called from ./spec/haml_lint/linter/documentation_links_spec.rb:103
     # ./spec/haml_lint/linter/documentation_links_spec.rb:22:in `block (4 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <top (required)>'

Finished in 0.04618 seconds (files took 2.22 seconds to load)
28 examples, 2 failures

Failed examples:

rspec './spec/haml_lint/linter/documentation_links_spec.rb[1:1:1:2:1]' # HamlLint::Linter::DocumentationLinks help_page_path behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint
rspec './spec/haml_lint/linter/documentation_links_spec.rb[1:2:1:2:1]' # HamlLint::Linter::DocumentationLinks help_page_url behaves like link validation rules when link_to points to the existing file with valid anchor is expected not to report a lint

@sselhorn Looks like changes introduced here gitlab-org/gitlab!104157 (diffs) are causing a master broken

Do you have any hints?

Later edit:

We found the cause and a fix

The missing ## Overview section in docs gitlab-org/gitlab!104157 (diffs)

we can fix it by adding a link to an existing section. Opening an MR for this

diff --git a/spec/haml_lint/linter/documentation_links_spec.rb b/spec/haml_lint/linter/documentation_links_spec.rb
index 49a720700da9..380df49cde35 100644
--- a/spec/haml_lint/linter/documentation_links_spec.rb
+++ b/spec/haml_lint/linter/documentation_links_spec.rb
@@ -17,7 +17,7 @@
     end
 
     context 'when link_to points to the existing file with valid anchor' do
-      let(:haml) { "= link_to 'Description', #{link_pattern}('index.md', anchor: 'overview'), target: '_blank'" }
+      let(:haml) { "= link_to 'Description', #{link_pattern}('index.md', anchor: 'user-account'), target: '_blank'" }
 
       it { is_expected.not_to report_lint }
     end
(END)