Follow-up from "Add Omnibus support for Puma"
The following discussions from !2801 (merged) should be addressed:
-
@balasankarc started a discussion: Just an FYI item to open a followup issue to convert it to a wrapper script, since we are using clustered mode of Puma and may want the same control over master and workers, like we do for unicorn.
(I remember typing this as part of my previous review. It didn't get added to the review, though.
🤔 ) -
@ibaum started a discussion: When switching between unicorn and puma, runit does leave behind a stray process that goes away if you run
systemctl restart gitlab-runsvdir
runsvdir -P /opt/gitlab/service log: not exist runsv puma: warning: unable to open supervise/stat.new: file do es not exist runsv puma: warning: unable to open supervise/stat.new: file does not exist runsv puma: warning: unable to open supervise/pid.new: file does not exist runsv puma: warning: unable to open log/supervise/pid.new: file does not exist runsv puma: warning: unable to open log/supervise/pid.new: file does not exist
I think this is more of an issue with our runit cookbook, this comment is meant for a follow up issue.