Skip to content

Build and ship fast-stats

What does this MR do?

This will provide more data for gitlabsos outputs and provide a tool that customers can use to analyze GitLab performance issues.

Related issues

Relates to #9218 (closed)

How to validate locally

  1. Run sudo /opt/gitlab/embedded/bin/fast-stats /var/log/gitlab/gitaly/current:
$ sudo /opt/gitlab/embedded/bin/fast-stats /var/log/gitlab/gitaly/current
METHOD                     COUNT     RPS    P99_ms    P95_ms   MEDIAN_ms    MAX_ms    MIN_ms    STDDEV      SCORE     %FAIL
Fsck                           4    0.00  591534.8  518360.3        27.9  609828.4      13.4  264053.5  2366139.2      0.00
FindCommit                    62    0.00       7.3       4.4         3.8       9.0       0.4       1.2      449.8      0.00
GetTreeEntries                27    0.00      14.3      12.4         9.9      14.9       4.5       1.7      385.5      3.70
CommitDiff                    38    0.00       7.9       7.2         5.5       8.0       4.3       0.9      299.8      0.00
DiffStats                     38    0.00       7.7       6.7         5.2       8.2       4.1       0.9      293.2      0.00
ListLastCommitsForTree         2    0.00     110.2     109.2        97.9     110.5      85.4      12.5      220.4      0.00
ListCommitsByOid              51    0.00       1.4       0.9         0.7       1.6       0.4       0.2       69.9      0.00
FindTag                        9    0.00       7.0       6.9         6.4       7.0       6.1       0.3       63.0      0.00
HasLocalBranches               9    0.00       6.9       6.6         5.8       7.0       5.6       0.4       62.2      0.00
FindDefaultBranchName          6    0.00      10.2      10.0         8.9      10.2       8.1       0.7       61.1      0.00
FindCommits                    9    0.00       5.2       5.0         4.6       5.2       4.1       0.3       46.5      0.00
ListRefs                       6    0.00       7.0       6.9         6.1       7.1       5.6       0.5       42.3      0.00
GetBlobs                       6    0.00       5.4       5.3         4.7       5.5       4.0       0.5       32.7      0.00
TreeEntry                      7    0.00       4.3       4.3         4.0       4.3       2.0       0.8       30.4     14.29
FindLicense                    2    0.00      14.8      14.8        14.8      14.8      14.8       0.0       29.6      0.00
LastCommitForPath              4    0.00       5.4       5.3         5.2       5.4       5.1       0.1       21.4      0.00
FindBranch                     2    0.00       6.3       6.2         5.9       6.3       5.6       0.3       12.5      0.00
GetInfoAttributes              2    0.00       4.2       4.2         4.0       4.2       3.8       0.2        8.4      0.00
GetLFSPointers                 1    0.00       3.7       3.7         3.7       3.7       3.7       0.0        3.7      0.00
RepositoryExists              11    0.00       0.3       0.2         0.1       0.3       0.1       0.1        3.5      0.00

Also run:

sudo gitlabsos --include-stats

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Stan Hu

Merge request reports

Loading