Fix deprecation warning about git_data_dirs

What does this MR do?

Deprecation logic works on node object, but we did not populate git_data_dirs on node object because at that time there was no need for it. But, we now have a need for it, and has to populate it there for deprecation warnings to work properly.

Testing

  1. On a default instance, confirm no warnings are shown at the end of gitlab-ctl reconfigure run.
  2. Edit /etc/gitlab/gitlab.rb and add the following to it and run reconfigure.
    git_data_dirs(
      {
        "default" => { "path" => "/var/opt/gitlab/git-data" },
        "alternative" => { "path" => "/mnt/git-data" }
      }
    )
    1. Ensure warning is shown at the end of gitlab-ctl reconfigure run.
    2. Ensure /var/opt/gitlab/gitaly/config.toml has the alternative storage in it.
    3. Ensure /var/opt/gitlab/gitlab-rails/etc/gitlab.yml has alternative storage in repositories.storages key.

Related issues

Closes #8960 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall

Merge request reports

Loading