Fix deprecation warning about git_data_dirs
What does this MR do?
Deprecation logic works on node object, but we did not populate git_data_dirs on node object because at that time there was no need for it. But, we now have a need for it, and has to populate it there for deprecation warnings to work properly.
Testing
- On a default instance, confirm no warnings are shown at the end of
gitlab-ctl reconfigurerun. - Edit
/etc/gitlab/gitlab.rband add the following to it and run reconfigure.git_data_dirs( { "default" => { "path" => "/var/opt/gitlab/git-data" }, "alternative" => { "path" => "/mnt/git-data" } } )- Ensure warning is shown at the end of
gitlab-ctl reconfigurerun. - Ensure
/var/opt/gitlab/gitaly/config.tomlhas the alternative storage in it. - Ensure
/var/opt/gitlab/gitlab-rails/etc/gitlab.ymlhas alternative storage inrepositories.storageskey.
- Ensure warning is shown at the end of
Related issues
Closes #8960 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-packagejobs have a green pipeline running against latest commit. -
Ifconfig/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then theTrigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed todev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall