Remove 'ci_jwt_signing_key' secret migrated to ApplicationSetting

What does this MR do?

The secret was actually never used:

1. Introduced in gitlab!34249 (diffs) and !4158 (diffs)
2. The first MR was reverted by gitlab!34646 (diffs) but the second was never reverted
3. The final solution was to add an ApplicationSetting: gitlab!43950 (merged)

The secret documentation is also removed from gitlab at gitlab!165829 (merged), and charts/gitlab at gitlab-org/charts/gitlab!3910 (merged).

Related issues

gitlab#451151 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

• MR title and description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• Latest Merge Result pipeline is green.
• When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

• The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
• If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
• If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
• If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes.
• Documentation created/updated.
• Tests added.
• Integration tests added to GitLab QA.
• Equivalent MR/issue for the GitLab Chart opened.
• Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

changed milestone to %17.4

added devopssystems groupdistribution maintenancepipelines sectioncore platform typemaintenance labels

assigned to @rymai

1 Message

Once your MR is ready for review you can comment @gitlab-bot ready <@user> to request the first review to someone. It's recommended that you pick the one suggested by the reviewer roulette. But you can ignore it and assign it to someone else if you see fit. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our Service-level objective (SLO). If you don't receive a response from the reviewer within the SLO, please mention @gitlab-org/distribution, or one of our Project Maintainers

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Reviewer	Maintainer
@clemensbeck (UTC+2, same timezone as @rymai)	@ibaum (UTC-5, 7 hours behind @rymai)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@rymai Can you tell us when it became an application setting item?

mentioned in issue gitlab#451151 (closed)

mentioned in merge request gitlab!165829 (merged)

mentioned in merge request gitlab-org/charts/gitlab!3910 (merged)

added maintenanceremoval label and removed maintenancepipelines label

changed the description

added 1 commit

• 74647c61 - Remove 'ci_jwt_signing_key' secret migrated to ApplicationSetting

Compare with previous version

changed title from Remove support of 'ci_jwt_signing_key' now that it's an ApplicationSetting to Remove 'ci_jwt_signing_key' secret migrated to ApplicationSetting

changed the description

added 1 commit

• 2983a41c - Remove 'ci_jwt_signing_key' secret migrated to ApplicationSetting

Compare with previous version

resolved all threads

marked the checklist item MR title and description are up to date, accurate, and descriptive. as completed

marked the checklist item MR targeting the appropriate branch. as completed

marked the checklist item Latest Merge Result pipeline is green. as completed

added workflowready for review label