Update consul from 1.16.6 to 1.18.2

What does this MR do?

Update consul from 1.16.6 to 1.18.2

• Update consul version shipping with Omnibus.
• Update supported BYO consul version.
• Fix minor bug in BYO consul helper script.

Changelog: changed

Closes #8351 (closed)

---

• 1.18 changelog: https://github.com/hashicorp/consul/blob/v1.18.0/CHANGELOG.md
• 1.17 changelog: https://github.com/hashicorp/consul/blob/v1.17.0/CHANGELOG.md
• jumping two consul versions at once is allowed per https://developer.hashicorp.com/consul/docs/upgrading/instructions#general-upgrade-path

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

• MR title and description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• Latest Merge Result pipeline is green.
• When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

• The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
• If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
• If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
• If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes.
  • 1. Test consul download helper

    $ gitlab-ctl consul-download
    $  /usr/local/bin/consul --version | head -n1
    Consul v1.18.2

  • 2. Confirm a HA environment is operational.

    Consul status of an multi node setup with a mix of nightly and branch images:

    $ docker exec -ti gitlab-test-gitlab-and-pgbouncer-1 consul members
    Node          Address        Status  Type    Build   Protocol  DC             Partition  Segment
    11c623f54e0b  10.0.0.7:8301  alive   server  1.16.6  2         gitlab_consul  default    <all>
    4bd93b27a50c  10.0.0.4:8301  alive   server  1.18.2  2         gitlab_consul  default    <all>
    5d1f3e126443  10.0.0.5:8301  alive   server  1.16.6  2         gitlab_consul  default    <all>
    5e80d77abfb7  10.0.0.6:8301  alive   server  1.16.6  2         gitlab_consul  default    <all>
    a85a71aaa855  10.0.0.3:8301  alive   server  1.18.2  2         gitlab_consul  default    <all>
    d3267aac0f13  10.0.0.8:8301  alive   server  1.16.6  2         gitlab_consul  default    <all>
    e3e1371f8ca7  10.0.0.2:8301  alive   server  1.18.2  2         gitlab_consul  default    <all>

  • You may use docker-compose to setup the environment

• Documentation created/updated.
• Tests added.
• Integration tests added to GitLab QA.
• Equivalent MR/issue for the GitLab Chart opened.
• Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.