Add new config option custom_html_header_tags
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do?
Add new config option custom_html_header_tags
, see gitlab!153877 (merged)
Note: This replaces !7643 (closed) (I forgot to use the community Fork there)
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Merge request reports
Activity
added Leading Organization label
Thanks for your contribution to GitLab @bufferoverflow!
- If you need help, comment @gitlab-bot help or come say hi on Discord.
- When you're ready for a review, comment on this merge request with @gitlab-bot ready.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
- To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @bufferoverflow
mentioned in merge request !7643 (closed)
1 Warning 87bf9d79: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @Alexand
(UTC+0)
@balasankarc
(UTC+5.5)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Danger Botadded linked-issue label
added 1 commit
- 1f539e82 - Add new config option custom_html_header_tags
added 1 commit
- 48446a09 - Add new config option custom_html_header_tags
added devopssystems groupdistribution group::distributionbuild labels
added sectioncore platform label
mentioned in issue gitlab-org/quality/triage-reports#17911 (closed)
- Resolved by Roger Meier
The generate-facts task is failing, see https://gitlab.com/gitlab-community/omnibus-gitlab/-/jobs/6977057762, ẁith
Please provide a private_token or auth_token for user
but I was unable to figure out what kind of token I have to set where.generate-facts
$ bundle exec rake build:generate_facts rake aborted! Gitlab::Error::MissingCredentials: Please provide a private_token or auth_token for user /builds/gitlab-community/omnibus-gitlab/gems/ruby/3.1.0/gems/gitlab-4.19.0/lib/gitlab/request.rb:94:in `authorization_header' /builds/gitlab-community/omnibus-gitlab/gems/ruby/3.1.0/gems/gitlab-4.19.0/lib/gitlab/request.rb:49:in `block (2 levels) in <class:Request>' /builds/gitlab-community/omnibus-gitlab/gems/ruby/3.1.0/gems/gitlab-4.19.0/lib/gitlab/client/jobs.rb:36:in `pipeline_jobs' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/api_client.rb:13:in `get_job_id' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/build/info/ci.rb:43:in `artifact_url' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/build/info/ci.rb:81:in `package_download_url' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/build/facts.rb:95:in `qa_trigger_vars' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/build/facts.rb:62:in `generate_env_file' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/build/facts.rb:13:in `generate' /builds/gitlab-community/omnibus-gitlab/lib/gitlab/tasks/build.rake:115:in `block (2 levels) in <top (required)>' /builds/gitlab-community/omnibus-gitlab/gems/ruby/3.1.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>' /usr/local/bin/bundle:25:in `load' /usr/local/bin/bundle:25:in `<main>' Tasks: TOP => build:generate_facts (See full trace by running task with --trace)
added featureaddition typefeature labels