Move Redis server information to NewRedisHelper

Move Redis server information to NewRedisHelper

- Continue conversion to the new style redis helper with
  refactors against the redis server functionality methods

Signed-off-by: Balasankar 'Balu' C <balasankar@gitlab.com>

What does this MR do?

Move Redis server information to NewRedisHelper that was added in !7269 (merged)

Testing

1. Install GitLab 16.8.0 which ships Redis 7.0.14
2. Create an empty file /etc/gitlab/skip-auto-reconfigure so that an upgrade will not automatically restart Redis.
3. Upgrade to package from this MR, which ships Redis 7.0.15
4. Run sudo gitlab-ctl reconfigure
5. See the warning about pending Redis restart at the end of the reconfigure log

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

• MR title and description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• Latest Merge Result pipeline is green.
• When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

• The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
• If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
• If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
• If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes.
• Documentation created/updated.
• Tests added.
• Integration tests added to GitLab QA.
• Equivalent MR/issue for the GitLab Chart opened.
• Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

files/gitlab-cookbooks/gitlab/libraries/redis_helper.rb

@@ -116,90 +116,6 @@ class RedisHelper
     end
   end
 
-  def running_version
-    return unless OmnibusHelper.new(@node).service_up?('redis')
-
-    commands = ['/opt/gitlab/embedded/bin/redis-cli']
-    commands << redis_cli_connect_options
-    commands << "INFO"
-    command = commands.join(" ")
-
-    command_output = VersionHelper.version(command)
-    raise "Execution of the command `#{command}` failed" unless command_output
-
-    version_match = command_output.match(/redis_version:(?<redis_version>\d*\.\d*\.\d*)/)
-    raise "Execution of the command `#{command}` generated unexpected output `#{command_output.strip}`" unless version_match
-
-    version_match['redis_version']
-  end
-
-  def installed_version
-    return unless OmnibusHelper.new(@node).service_up?('redis')
-
-    command = '/opt/gitlab/embedded/bin/redis-server --version'
-
-    command_output = VersionHelper.version(command)
-    raise "Execution of the command `#{command}` failed" unless command_output
-
-    version_match = command_output.match(/Redis server v=(?<redis_version>\d*\.\d*\.\d*)/)
-    raise "Execution of the command `#{command}` generated unexpected output `#{command_output.strip}`" unless version_match
-
-    version_match['redis_version']
-  end
-
-  def redis_cli_connect_options
-    args = []
-    if RedisHelper::Checks.is_redis_tcp?
-      args = redis_cli_tcp_connect_options(args)
-    else
-      args << "-s #{redis['unixsocket']}"
-    end
-
-    args << "-a '#{Gitlab['redis']['password']}'" if Gitlab['redis']['password']
-
-    args
-  end
-
-  def redis_cli_tcp_connect_options(args)
-    args << ["-h #{redis['bind']}"]
-    port = redis['port'].to_i
-
-    if port.zero?
-      args = redis_cli_tls_options(args)
-    else
-      args << "-p #{port}"
-    end
-
-    args
-  end
-
-  def redis_cli_tls_options(args)
-    tls_port = redis['tls_port'].to_i
-
-    args << "--tls"
-    args << "-p #{tls_port}"
-    args << "--cacert '#{redis['tls_ca_cert_file']}'" if redis['tls_ca_cert_file']
-    args << "--cacertdir '#{redis['tls_ca_cert_dir']}'" if redis['tls_ca_cert_dir']
-
-    return args unless client_certs_required?
-
-    raise "Redis TLS client authentication requires redis['tls_cert_file'] and redis['tls_key_file'] options" unless client_cert_and_key_available?
-
-    args << "--cert '#{redis['tls_cert_file']}'"
-    args << "--key '#{redis['tls_key_file']}'"
-
-    args
-  end
-
-  def client_certs_required?
-    redis['tls_auth_clients'] == 'yes'
-  end
-
-  def client_cert_and_key_available?
-    redis['tls_cert_file'] && !redis['tls_cert_file'].empty? &&
-      redis['tls_key_file'] && !redis['tls_key_file'].empty?
-  end
-
   class Checks
     class << self
       def is_redis_tcp?