Skip to content

Bump nginx to 1.24.0

Clemens Beck requested to merge update-nginx into master

What does this MR do?

Bump nginx to 1.24.0

Bump nginx from 1.20.2 to 1.24.0 and
remove now unnecessary patches.

Changelog: changed

Patch for CVE can be removed, as its fixed in nginx >= 1.21.0 nvd.nist.gov.

This also adds nginx to the deps.yml for automated bump MRs in the future.

Related issues

Closes #7058 (closed)

Test Plan

  1. Install the package/Run the Docker image

  2. Check the nginx version

    $ /opt/gitlab/embedded/sbin/nginx -version
    nginx version: nginx/1.24.0
  3. Check vts module works as expected

    curl localhost:8060/metrics

    Note to reviewers: The module was not tested for nginx 1.23/1.24.

    Since nginx 1.22 is EOL, this MR still suggests bumping to 1.24, as local testing works as expected and there seem to be no known issues for nginx 1.24 tracked upstream.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Clemens Beck

Merge request reports