Upgrade nginx to 1.24
nginx 1.24 is now the nginx stable branch as of May 2023, and we should upgrade our bundled nginx to that version.
- Investigate changelog for any deprecations that we need to deal with
- Update the version, and ensure builds and qa tests all work
- Its a good idea to do a manual Letsencrypt test to ensure that is working
- Check instance against SSLlabs to see if there are any recommended changes we should consider making
In the meantime we are applying security patches that come as our scanning detects the CVEs in the current shipped nginx version.
Designs
- Show closed items
Related merge requests 1
When this merge request is accepted, this issue will be closed automatically.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- DJ Mountney changed milestone to %15.6
changed milestone to %15.6
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
@twk3 Happy to take this and learn how to upgrade stuff like this (if this is available for
Community Contribution
, let me know if you can guide me a bit!Edited by Mehul SharmaCollapse replies - Author Contributor
@mehulsharma thanks for the offer.
Our omnibus project doesn't do builds in forks at the moment (something we are working on), so for a build task like this you will need to start by setting up a development environment for this project and get omnibus builds going locally. https://gitlab.com/gitlab-org/omnibus-gitlab/-/tree/master/doc/development
But another helpful step would be to do some research on anything from nginx 1.20 that was deprecated/removed in 1.22, or breaking changes, and searching this codebase for any use of those and chronicling them in this issue.
cc\ @balasankarc
- DJ Mountney changed milestone to %15.7
changed milestone to %15.7
- DJ Mountney mentioned in issue gitlab-org/distribution/team-tasks#1131 (closed)
mentioned in issue gitlab-org/distribution/team-tasks#1131 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %15.8
changed milestone to %15.8
- 🤖 GitLab Bot 🤖 added missed:15.7 label
added missed:15.7 label
- DJ Mountney changed milestone to %Next 1-3 releases
changed milestone to %Next 1-3 releases
- DJ Mountney removed For Scheduling label
removed For Scheduling label
- DJ Mountney added Deliverable priority2 severity2 labels
added Deliverable priority2 severity2 labels
- 🤖 GitLab Bot 🤖 added missed-deliverable label
added missed-deliverable label
- DJ Mountney added to epic &10274 (closed)
added to epic &10274 (closed)
- Peter Lu added Distribution KR2 Distribution OBJ1 labels
added Distribution KR2 Distribution OBJ1 labels
- Peter Lu changed title from Upgrade nginx to 1.22 to Upgrade nginx to 1.24
changed title from Upgrade nginx to 1.22 to Upgrade nginx to 1.24
- Peter Lu changed the description
Compare with previous version changed the description
@twk3 - I updated the description to the latest stable 1.24, as 1.22 became EOL last month.
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12432 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12432 (closed)
- Nailia Iskhakova added quad-planningcomplete-no-action label
added quad-planningcomplete-no-action label
- Clemens Beck assigned to @clemensbeck
assigned to @clemensbeck
- Clemens Beck mentioned in merge request !6900 (merged)
mentioned in merge request !6900 (merged)
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- Balasankar 'Balu' C closed with merge request !6900 (merged)
closed with merge request !6900 (merged)
- Balasankar 'Balu' C mentioned in commit d005fbbd
mentioned in commit d005fbbd
- 🤖 GitLab Bot 🤖 added workflowcomplete label
added workflowcomplete label