Skip to content

Use goexperiment boringcrypto for golang 1.19 fips

DJ Mountney requested to merge goexperiment-fips-mode into master

What does this MR do?

Adds a env flag to the workhorse and gitlab-pages containers in order for them to compile with golang 1.19+ in fips mode.

The env flag throws an error in 1.17 and 1.18, so we need to gate the check while we are still running 1.18 and testing 1.19

There is work to move these into the makefiles, which would make this change unneeded, which have already been done for workhorse gitaly and shell. The gitlab pages MR is:

Related issues

Part of &9495 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by DJ Mountney

Merge request reports