Skip to content

Fix fips builds for Golang 1.19

DJ Mountney requested to merge fips-golang-1.19 into master

What does this MR do?

Updates the go build environment to include an extra flag for fips mode on newer golang versions.

Testing

You can use a ubi fips docker image we build for gitaly for testing:

Golang 1.19 fips registry.gitlab.com/gitlab-org/gitlab-build-images/ubi-8.6-ruby-3.0-golang-1.19-rust-1.65:git-2.36

Golang 1.18 fips registry.gitlab.com/gitlab-org/gitlab-build-images/ubi-8.6-ruby-3.0-golang-1.18-rust-1.65:git-2.36

  1. Clone and cd into this branch
  2. Run export FIPS_MODE=1
  3. Run make build
    • Should succeed with binary is correctly built in FIPS mode
  4. Run make test

Both 1.19 and 1.18 should succeed

TODO

Merge request reports