Skip to content

Add log directory group support to all services

Jason Young requested to merge 6731-svlogd-logdir-group-all into master

What does this MR do?

This is a follow-on MR to !6701 (merged) - and a replacement for !6502 (closed)

This implements functionality to allow for a global (using logging['log_group']) or per-service (e.g. gitaly['log_group']) configuration setting that will be set as the group on Omnibus-managed log directories; will be used as the execution group for launching svlogd with chpst for the runit-managed services in Omnibus; and will be the group attached to the rotated log files for logrotate (making use of the su directive)

This MR contains a huge number of changes due to the number of services involved, but the vast majority of it is repetition for log directory creation - as well as per-service tests for the log_directory and chpst settings (this MR corrects a deficiency that not all services were testing for the permissions/mode on the log_directory)

More details, as well as a test plan are in the description for !6701 (merged)

Related issues

Closes Feature Proposal: Omnibus Configuration to Adju... (#6731 - closed)

Closes Make log directory creation by service recipes ... (#4606 - closed)

Also provides a partial solution for gitlab#1527

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • [ ] Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated (Development documentation to come in follow-up)
  • Tests added
  • [ ] Integration tests added to GitLab QA
  • [ ] Equivalent MR/issue for the GitLab Chart opened
Edited by Jason Young

Merge request reports