Skip to content

Drop mail_room as a separate dependency

Stan Hu requested to merge sh-drop-mailroom-dep into master

What does this MR do?

We introduced mail_room as a separate dependency because updating mail_room required an updated net-imap gem. This gem attempted to install the digest gem, but due to a bug present in Ruby 2.7 (https://bugs.ruby-lang.org/issues/17761), the installation failed and caused Cloud Native GitLab builds to fail (gitlab-com/gl-infra/production#4053 (closed)).

We've updated to Ruby 3.0.5 for Cloud Native GitLab images now and have already bumped the net-imap dependency in gitlab!115755 (merged). With gitlab!116494 (merged), we've now updated GitLab Rails to use mail_room v0.0.23. As a result, we no longer need a separate dependency for Omnibus.

Removing this dependency makes it easier to update mail_room since we only need to bump the Gemfile in GitLab Rails.

I've verified only one version gets shipped now:

root@gitlab:/opt/gitlab/embedded/bin# ./gem list | grep mail_room
gitlab-mail_room (0.0.23)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Stan Hu

Merge request reports