Feat(wrapper): add GITLAB_PRE_RECONFIGURE_SCRIPT
What does this MR do?
If the env variable GITLAB_PRE_RECONFIGURE_SCRIPT
is set, we will eval it in /assets/wrapper
This will be useful for run a few minor commands specific to my environment before starting the services. This would permit users to inject customization before the initial reconfiguration. For example change sshd port when running gitlab in network_mode=host
without mounting /assets/sshd_config
This is same as GITLAB_POST_RECONFIGURE_SCRIPT
(same code) but before reconfigure and starting services.
Resolve:
Merge request reports
Activity
Hey @ergoz!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @ergoz
@gitlab-bot ready
added 1st contribution label
added workflowready for review label and removed workflowin dev label
added 1 commit
- fe19d3e2 - fix(wrapper): change GITLAB_PRE_RECONFIGURE_SCRIPT position higher
added devopssystems groupdistribution labels
added sectioncore platform label
mentioned in issue gitlab-org/quality/triage-reports#11597 (closed)
- Resolved by João Alexandre Cunha
@clemensbeck do you have time to look at this community contribution?
mentioned in issue gitlab-org/quality/triage-reports#11598 (closed)
added featureenhancement typefeature labels
- Resolved by Balasankar 'Balu' C
For the reviewer: be aware of the security implications of the current implementation presented here.
@ergoz I see where the value of the proposed feature. I, for one, would like to see this concept included into the Omnibus' container (
gitlab/gitlab-?e
). We may have to refine it to have a some assurances, from a security perspective.
mentioned in issue gitlab-org/quality/triage-reports#11800 (closed)
requested review from @Alexand
added workflowin review label and removed workflowready for review label
added docs-only label