Deprecate legacy Gitaly configuration options
What does this MR do?
Gitaly's configuration in Omnibus has been updated to structurally match Gitaly's own configuration. The new configuration keys go under the gitaly['configuration']
key. This commit deprecates the old keys that were replaced by the new configuration.
Related issues
General issue: gitaly#4467 (closed)
New config: !6621 (merged)
Linked migration instructions: gitlab!110784 (merged)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Merge request reports
Activity
added Category:Gitaly devopssystems groupgitaly sectioncore platform labels
assigned to @samihiltunen
2 Warnings You've made some changes in the cookbooks, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding the typemaintenance label in that case.You've made some changes at the locations which contain user facing configuration.
That's OK as long as you're refactoring existing code and not adding any new
configuration. If you are adding new user facing configuration, consider adding
to gitlab.rb.template located in files/gitlab-config-template/gitlab.rb.template .
Otherwise, please consider adding the typemaintenance label in that case.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitaly#4755 (closed)
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@samihiltunen - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added maintenancerefactor typemaintenance labels
@pursultani could you please review this one as well given you're reviewing !6621 (merged)? I've based this on !6669 (merged) as otherwise there would be a conflict, only the last commit is new in this MR.
requested review from @pursultani
changed milestone to %15.9
added workflowin review label
- Resolved by Hossein Pursultani
mentioned in merge request gitlab!110945 (merged)
mentioned in merge request !6658 (merged)
- Resolved by Hossein Pursultani
@samihiltunen this needs a rebase.
added 112 commits
-
cfb91754...983ab261 - 111 commits from branch
master
- 3188fd7f - Deprecate legacy Gitaly configuration options
-
cfb91754...983ab261 - 111 commits from branch
Passing to @rmarshall for maintainer review.
requested review from @rmarshall
changed milestone to %15.10
added missed:15.9 label
mentioned in merge request !6621 (merged)
- Resolved by Robert Marshall
- Resolved by Robert Marshall
The deprecations worked as expected, just the one open question for discussion.
added 1 commit
- 4512534d - Deprecate legacy Gitaly configuration options
mentioned in merge request gitlab!113286 (merged)
mentioned in commit 10ac468e
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request gitlab!120644 (merged)