Skip to content
Snippets Groups Projects

Deprecate legacy Gitaly configuration options

Merged Sami Hiltunen requested to merge smh-deprecate-gitaly-config into master
All threads resolved!

What does this MR do?

Gitaly's configuration in Omnibus has been updated to structurally match Gitaly's own configuration. The new configuration keys go under the gitaly['configuration'] key. This commit deprecates the old keys that were replaced by the new configuration.

Related issues

General issue: gitaly#4467 (closed)
New config: !6621 (merged)
Linked migration instructions: gitlab!110784 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in merge request gitlab!110945 (merged)

  • Sami Hiltunen mentioned in merge request !6658 (merged)

    mentioned in merge request !6658 (merged)

  • Hossein Pursultani resolved all threads

    resolved all threads

  • Hossein Pursultani approved this merge request

    approved this merge request

  • Sami Hiltunen added 112 commits

    added 112 commits

    Compare with previous version

  • Hossein Pursultani resolved all threads

    resolved all threads

  • Passing to @rmarshall for maintainer review.

  • requested review from @rmarshall

  • changed milestone to %15.10

  • Sami Hiltunen mentioned in merge request !6621 (merged)

    mentioned in merge request !6621 (merged)

  • Sami Hiltunen added 1 commit

    added 1 commit

    • 4512534d - Deprecate legacy Gitaly configuration options

    Compare with previous version

  • Evan Read mentioned in merge request gitlab!113286 (merged)

    mentioned in merge request gitlab!113286 (merged)

  • Robert Marshall resolved all threads

    resolved all threads

  • Robert Marshall approved this merge request

    approved this merge request

  • Robert Marshall marked the checklist item MR has a green pipeline on GitLab.com as completed

    marked the checklist item MR has a green pipeline on GitLab.com as completed

  • Robert Marshall marked the checklist item trigger-package has a green pipeline running against latest commit as completed

    marked the checklist item trigger-package has a green pipeline running against latest commit as completed

  • Robert Marshall mentioned in commit 10ac468e

    mentioned in commit 10ac468e

  • added workflowstaging label and removed workflowcanary label

  • Sami Hiltunen mentioned in merge request gitlab!120644 (merged)

    mentioned in merge request gitlab!120644 (merged)

  • Please register or sign in to reply
    Loading