Ensure Workhorse is built in FIPS mode
What does this MR do?
Previously Workhorse was not compiled properly for FIPS since the fips
build tag was not defined, so LabKit's fips.Enabled()
would
erroneously return false
. The FIPS_MODE=1
environment variable makes Workhorse activate the right build settings.
This came out an investigation of Maven package handling in gitlab#380559 (closed).
Related issues
Testing
[stanhu@stanhu-fips1 bin]$ ./gitlab-workhorse
INFO[0000] Starting build_time=20221216.094924 version=11-10-0cfa69752d8-74ffd66ae-ee-187173-g031da1d300c1
INFO[0000] FIPS mode is enabled. Using an external SSL library.
INFO[0000] Running upstream server address="localhost:8181" network=tcp
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Merge request reports
Activity
added devopssystems groupdistribution sectioncore platform labels
assigned to @stanhu
- A deleted user
added typebug label
2 Warnings You've made some changes to the software definitions.
Any change in software definition requires:
- package rebuild to verify that builds across the supported platforms are successful.
- manual verification to confirm the package is installable
- uses an approved license
If the change does not affect existing functionality, for example when
resolvingrubocop
warnings, adding comments, or fixing typos, add one of
the following labels:Please add a merge request subtype to this merge request. 1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersIf needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded FIPS label
changed milestone to %15.8
mentioned in issue gitlab#380559 (closed)
This is great news, thanks! I feel like this might be the cause behind gitlab#385477 (closed) as well. Do we know when this fix might be released?
added workflowready for review label
requested review from @WarheadsSE
marked the checklist item Equivalent MR/issue for the GitLab Chart opened as completed
added Pick into 15.6 label
The failed pipeline is buried deep in
trigger-generated-jobs
, withinee:elasticsearch
https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/724453248 / https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/3484779466The two failures there are
Unable to find css "[data-qa-selector=\"code_tab\"],.qa-code-tab"
. Examining their test outputs, I don't see anything related to these changes. Proceeding.- Resolved by Jason Plum
mentioned in commit bf69801b
changed milestone to %15.7
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request gitlab!107059 (merged)
added releasedcandidate label
added bugfunctional label
picked the changes into the branch
15-6-stable-patch-7
with commit 22eabafcmentioned in commit 22eabafc
Automatically picked into !6641 (merged), will merge into
15-6-stable
ready for15.6.7
.removed Pick into 15.6 label
mentioned in merge request !6641 (merged)
mentioned in issue gitlab-org/build/CNG#1838 (closed)