Skip to content
Snippets Groups Projects

Ensure Workhorse is built in FIPS mode

Merged Stan Hu requested to merge sh-build-workhorse-fips into master
All threads resolved!

What does this MR do?

Previously Workhorse was not compiled properly for FIPS since the fips build tag was not defined, so LabKit's fips.Enabled() would erroneously return false. The FIPS_MODE=1 environment variable makes Workhorse activate the right build settings.

This came out an investigation of Maven package handling in gitlab#380559 (closed).

Related issues

gitlab#380559 (closed)

Testing

[stanhu@stanhu-fips1 bin]$ ./gitlab-workhorse
INFO[0000] Starting                                      build_time=20221216.094924 version=11-10-0cfa69752d8-74ffd66ae-ee-187173-g031da1d300c1
INFO[0000] FIPS mode is enabled. Using an external SSL library.
INFO[0000] Running upstream server                       address="localhost:8181" network=tcp

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jason Plum resolved all threads

    resolved all threads

  • Jason Plum approved this merge request

    approved this merge request

  • merged

  • Jason Plum mentioned in commit bf69801b

    mentioned in commit bf69801b

  • Stan Hu changed milestone to %15.7

    changed milestone to %15.7

  • added workflowstaging label and removed workflowcanary label

  • Stan Hu mentioned in merge request gitlab!107059 (merged)

    mentioned in merge request gitlab!107059 (merged)

  • GitLab Release Tools Bot picked the changes into the branch 15-6-stable-patch-7 with commit 22eabafc

    picked the changes into the branch 15-6-stable-patch-7 with commit 22eabafc

  • Jason Plum mentioned in commit 22eabafc

    mentioned in commit 22eabafc

  • Automatically picked into !6641 (merged), will merge into 15-6-stable ready for 15.6.7.

  • mentioned in merge request !6641 (merged)

  • Please register or sign in to reply
    Loading