Skip to content

gitaly: Fix migration of gitconfig with subsections

Patrick Steinhardt requested to merge pks-gitconfig-fix-migration into master

What does this MR do?

As we're migrating to the new gitaly['gitconfig'] format, we have implemented a migration that automatically converts from the old-style format in omnibus_gitconfig['system'] to the new format. The migration didn't take into account gitconfig with subsections of the form http."http://example.com".insteadOf though, so the migrated gitconfig is broken and causes errors.

Fix this bug by carefully trying to split up the old-style configuration into its different components.

Related issues

Prereq for !6447 (closed).

Related to #6800 (closed).

Related to gitaly#4230 (closed).

Part of &8069 (closed).

Related to #6889.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports