Skip to content

Update dependency_decisions.yml for new license_finder

Andrew Patterson requested to merge 7083-unknown-licenses into master

What does this MR do?

Updates dependency_decisions.yaml with entries for new dependencies found with an unknown license by newer versions of license_finder (>- 6.6.2). In particular:

  • github.com/hashicorp/consul/api
  • github.com/hashicorp/consul/sdk
  • github.com/circonus-labs/circonus-gometrics
  • github.com/circonus-labs/circonusllhist
  • github.com/gorhill/cronexpr
  • github.com/rcrowley/go-metrics
  • github.com/tj/go-redirects
  • github.com/alicebob/gopher-json
  • github.com/pavelmemory/go-license-detector/v4

Related issues

Closes #7083 (closed)
Related gitlab-omnibus-builder#49 (closed)
Related #6998 (closed)

Test plan

  • Build output shows dependency is present and has the correct valid license. Note you have to do a local build with an updated version of license_finder to see these licenses (try gem install license_finder -v 6.14.2):
    • github.com/hashicorp/consul/api
    • github.com/hashicorp/consul/sdk
    • github.com/circonus-labs/circonus-gometrics
    • github.com/circonus-labs/circonusllhist
    • github.com/gorhill/cronexpr
    • github.com/rcrowley/go-metrics
    • github.com/tj/go-redirects
    • github.com/alicebob/gopher-json
    • github.com/pavelmemory/go-license-detector/v4
  • license:check/analyzer.rb does not complain about unknown or blacklisted licenses.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on the dev.gitlab.org mirror for this branch if the change is touching anything besides documentation or internal cookbooks. Please note that feature branches are not automatically mirrored to dev.gitlab.org, and should be manually pushed whenever necessary.
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Andrew Patterson

Merge request reports