Updated license_finder finds dependencies with unknown licenses
Summary
Licenses for some dependencies are shown as unknown license
when using a version of license_finder
>= 6.6.2. Example:
Problematic softwares: 9
./api - - unknown - Unknown license
./sdk - - unknown - Unknown license
github.com/circonus-labs/circonus-gometrics - v2.3.1 - unknown - Unknown license
github.com/circonus-labs/circonusllhist - v0.1.3 - unknown - Unknown license
github.com/gorhill/cronexpr - v0.0.0-20180427100037-88b0669f7d75 - unknown - Unknown license
github.com/rcrowley/go-metrics - v0.0.0-20200313005456-10cdbea86bc0 - unknown - Unknown license
github.com/tj/go-redirects - v0.0.0-20180508180010-5c02ead0bbc5 - unknown - Unknown license
github.com/alicebob/gopher-json - v0.0.0-20200520072559-a9ecdc9d1d3a - unknown - Unknown license
github.com/pavelmemory/go-license-detector/v4 - v4.3.1-0.20220801101717-a7c9e28533cf - unknown - Unknown license
Steps to reproduce
Follow the steps in https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/doc/build/build_package.md, e.g.,
- docker pull registry.gitlab.com/gitlab-org/gitlab/gitlab-assets-ee:master
- docker create --name gitlab_asset_cache registry.gitlab.com/gitlab-org/gitlab/gitlab-assets-ee:master
- docker pull registry.gitlab.com/gitlab-org/gitlab-omnibus-builder/debian_11:3.5.0
- docker run -v omnibus-gitlab:/omnibus-gitlab -v gitlab-assets:/gitlab-assets -it registry.gitlab.com/gitlab-org/gitlab-omnibus-builder/debian_11:3.5.0 bash
- export ALTERNATIVE_SOURCES=true
- export ASSET_PATH=/gitlab-assets
- export ee=true
- cd /omnibus-gitlab
- bundle install
- bundle binstubs --all
- gem install license_finder -v 6.6.2
- bundle exec rake build:project
What is the current bug behavior?
Build fails, some dependencies show up with Unknown license
.
What is the expected correct behavior?
Build should succeed. All dependencies should show a valid license.