Skip to content

Enable frame pointer in PostgreSQL compile options

Stan Hu requested to merge sh-enable-framepointer-postgresql into master

What does this MR do?

As we did with !4030 (merged) and !3421 (merged), enabling the frame pointer is critical to being able to use perf with PostgreSQL.

This is enabled in the PostgreSQL PGDG builds (https://wiki.postgresql.org/wiki/Apt). I was not able to get a flamegraph from the Omnibus PostgreSQL build in gitaly#3973 (closed) without this compile option, so I ended up switching to a PGDG build.

Example flamegraph taken with this build:

image

Related issues

gitaly#3973 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Stan Hu

Merge request reports